[BI-2778] Deprecate additionalinfo usage for level and use obs unit lvl#459
Merged
jloux-brapi merged 3 commits intodevelopfrom Mar 10, 2026
Merged
[BI-2778] Deprecate additionalinfo usage for level and use obs unit lvl#459jloux-brapi merged 3 commits intodevelopfrom
jloux-brapi merged 3 commits intodevelopfrom
Conversation
Open
5 tasks
HMS17
requested review from
a team and
jloux-brapi
and removed request for
a team
jloux-brapi
approved these changes
Mar 10, 2026
Comment on lines
+99
to
+103
| computed: { | ||
| StringFormatters() { | ||
| return StringFormatters | ||
| } | ||
| }, |
Contributor
There was a problem hiding this comment.
Now that I'm seeing this for a second time, I'm wondering if there's a more elegant way to do this without this same boilerplate code.
If we can create some sort of global obj/utility that can be used by any component I think we could do that, but I do know it's more work.
For now, I think what you have is fine, but we should start to think about this if the use of StringFormatters continues to get larger.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Story: BI-2778 - Deprecate additionalinfo usage for level and use obs unit level
Changes to ensure front end display of obs lvl is capitalized.
Dependencies
bi-api: feature/BI-2778
Testing
see bi-api
Checklist: